Fix profiling SeparableConv1D and SeparableConv2D #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Just noticed that there is one unwnated merge commit. I'll fix this later today. |
jmitrevs
added
please test
vloncar
approved these changes
Oct 20, 2023
| @@ -346,6 +350,7 @@ def activations_keras(model, X, fmt='longform', plot='boxplot'): | |||
| outputs = _get_outputs( | |||
| [layer for layer in model.layers if not isinstance(layer, keras.layers.InputLayer)], X, model.input | |||
| ) | |||
| outputs = dict(zip([layer.name for layer in model.layers if not isinstance(layer, keras.layers.InputLayer)], outputs)) | |||
There was a problem hiding this comment.
This is a nice catch that we missed in the #863
calad0i
added a commit
to calad0i/hls4ml
that referenced
this pull request
Nov 7, 2023
🎉 Add proxy_model support format Fix broken import Add parallelization_factor propagation Add overriding warning Purge linear layers for proxy model configured layers Fix repack_stream optimizer inheirt original precision format not-my-code add handler, fix type enforcement Speed up Keras profiling (fastmachinelearning#863) * Speed up Keras profiling * update function name --------- Co-authored-by: Javier Duarte <jduarte@ucsd.edu> [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0) - [github.com/asottile/pyupgrade: v3.14.0 → v3.15.0](asottile/pyupgrade@v3.14.0...v3.15.0) Fix profiling SeparableConv1D and SeparableConv2D (fastmachinelearning#891) * Profiling: Fix suffixes for SeparableConv1D&2D * Profiling: transform list to dict where dict is expected --------- Co-authored-by: Quentin Berthet <quentin.berthet@cern.ch> Add support for filt_height==1 for streaming quartus conv2d (fastmachinelearning#886) Fix config structure name in pragma for SeparableConv1D (fastmachinelearning#884) * Raise exception if Vivado command fail * Duplicate sepconv2d test for sepconv1d * Test that csynth is working for sepconv1d * Define multiplier_limit in nnet::conv1d_config (for sepconv1d) * Revert build test --------- Co-authored-by: Quentin Berthet <quentin.berthet@cern.ch> Co-authored-by: Vladimir Loncar <vloncar@users.noreply.github.com> [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 23.9.1 → 23.10.0](psf/black@23.9.1...23.10.0) rename, minor bug fix fix multi clones w/ diff outs in stream io fix test Fix quartus writer with io_stream and multi-output fix weight fp write length add test Fix: update weight writer digits Fix clone precision inheriting Add relu6 stream support Fix semi-heterogeneous mask generation Add test and fixed_point_quantizer format Revert "Add relu6 stream support" This reverts commit d05cbaa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #890, profiling model using SeparableConv1D or SeparableConv2D fail.
The application of theses two commit fix the test cases decribed in the issue.
closes #890
Type of change
Tests
Tests explaining how to reproduce the problem have been provided in the original issue #890.
Checklist
pre-commiton the files I edited or added.