Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group more tests per YAML to reduce the number of envs created #996

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Apr 11, 2024

Description

As discussed during the dev meeting, the CI tests create a new environment for every test file, eventually exhausting the disk space of k8 runners. With this PR we reduce the number of parallel tests that run at the same time, thus reducing the number of environments created.

Type of change

  • Other (Specify) - Testing infrastructure update

Tests

I arbitrarily set the number of test files that are run as one "unit" as 5. May need several iterations to fine-tune this.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar vloncar added the please test Trigger testing by creating local PR branch label Apr 11, 2024
@vloncar vloncar added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Apr 18, 2024
@jmitrevs jmitrevs merged commit 9df3e14 into fastmachinelearning:main Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants