cope with and generate JMAP wrappers #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, as_triple/s is now totally a thing
rjbs
force-pushed
the
wrappers-delight
branch
from
da7ce41
to
0a6ba69
Compare
mmcclimon
approved these changes
Jan 16, 2018
| for my $call (@$calls) { | ||
| my $request = _ARRAY0($input_request) | ||
| ? { methodCalls => $input_request } | ||
| : { %$input_request }; |
There was a problem hiding this comment.
Why not just use $input_request here?
(update: I guess you want to keep the original around to inspect later. Never mind, then!)
t/basic.t
Outdated
| [ | ||
| jstr('atePies'), | ||
| { howMany => jnum(100), tastiestPieId => jstr(123) }, | ||
| jstr('a'), | ||
| ], | ||
| "as_struct", | ||
| "as_triple", |
wolfsage
approved these changes
Jan 16, 2018
lib/JMAP/Tester.pm
Outdated
| @@ -205,7 +209,7 @@ L<JMAP::Tester::Response> objects. | |||
| =cut | |||
|
|
|||
| sub request { | |||
| my ($self, $calls) = @_; | |||
| my ($self, $input_request, $arg) = @_; | |||
There was a problem hiding this comment.
Yeah, I meant to add a means to request/demand wrapping or not. I'll just drop it until then.
| $request->{methodCalls} = \@suffixed; | ||
|
|
||
| $request = $request->{methodCalls} | ||
| if $ENV{JMAP_TESTER_NO_WRAPPER} && _ARRAY0($input_request); |
There was a problem hiding this comment.
I don't understand the _ARRAY0($input_request) here.
I suppose what we're saying is JMAP_TESTER_NO_WRAPPER means "Do not wrap old-style calls" but it does not mean "Unwrap new style calls".
Okay.
|
|
||
| C<as_struct> returns an arrayref containing the result of calling C<as_struct> | ||
| on each sentence in the paragraph. C<as_stripped_struct> removes JSON types. | ||
| C<as_triples> returns an arrayref containing the result of calling C<as_triples> |
There was a problem hiding this comment.
Calls C<as_triple> on each sentence
rjbs
force-pushed
the
wrappers-delight
branch
from
8adb762
to
c133b61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, as_triple/s is now totally a thing