Fix umlauts with python2 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantus
force-pushed
the
fix-umlauts-with-python2
branch
from
1b328c1
to
b1f61a1
Compare
|
@jpvanhal: Ping |
jpvanhal
requested changes
Mar 24, 2017
tox.ini
Outdated
| @@ -6,15 +6,17 @@ deps = | |||
| flake8 | |||
| isort | |||
| pytest | |||
| future | |||
tox.ini
Outdated
| isort --recursive --diff . | ||
| isort --recursive --check-only . | ||
|
|
||
| [testenv:docs] | ||
| basepython = python | ||
| deps = | ||
| Sphinx | ||
| future |
tox.ini
Outdated
| commands = | ||
| py.test {posargs} | ||
| flake8 | ||
| flake8 qstring tests |
There was a problem hiding this comment.
I'd prefer excluding the problematic files/directories instead of whitelisting. The solution above would prevent flake8 from linting setup.py and docs/conf.py for example. Also, I'd like to have this sort of configuration in [flake8] section in tox.ini so that it's applied regardless of the way you invoke flake8.
quantus
force-pushed
the
fix-umlauts-with-python2
branch
from
b1f61a1
to
33e854f
Compare
|
Thanks for the feedback! I have now fixed all the issues. |
jpvanhal
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.