This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
fpm.dependency management #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 30, 2021 16:49
amitu
reviewed
Dec 2, 2021
|
|
||
| impl Dependency { | ||
| pub fn parse(b: &ftd::p2::Document) -> Vec<Dependency> { | ||
| b.to_owned().instances("fpm#dependency").unwrap() |
There was a problem hiding this comment.
Lets return Result instead of panicking.
amitu
reviewed
Dec 2, 2021
src/dependency.rs
Outdated
| k => k.to_string(), | ||
| }; | ||
|
|
||
| let response = reqwest::get(download_url).await.expect(""); |
There was a problem hiding this comment.
Remove .expect() and use .await?.
amitu
reviewed
Dec 2, 2021
|
|
||
| let response = reqwest::get(download_url).await.expect(""); | ||
|
|
||
| std::fs::create_dir_all("./.packages/.cache").expect("failed to create build folder"); |
amitu
reviewed
Dec 2, 2021
src/dependency.rs
Outdated
| let download_path = format!("./.packages/.cache/{}.zip", self.name.replace("/", "__")); | ||
| let path = std::path::Path::new(download_path.as_str()); | ||
| let mut file = match std::fs::File::create(&path) { | ||
| Err(why) => panic!("couldn't create {}", why), |
added 2 commits
December 2, 2021 14:29
amitu
reviewed
Dec 2, 2021
| clap = "2.33.3" | ||
| home = "0.5.3" | ||
| reqwest = { version = "0.11.6"} |
There was a problem hiding this comment.
We should create a lint or auto formatter that converts such lines into reqwest = "0.11.6".
amitu
reviewed
Dec 2, 2021
| unreachable!("must never happen") | ||
| } | ||
|
|
||
| #[derive(thiserror::Error, Debug, serde_derive::Deserialize)] |
There was a problem hiding this comment.
Why are we deriving Deserialise?
amitu
reviewed
Dec 2, 2021
Comment on lines
+41
to
+46
| #[error("{doc_id}:{line_number} -> {message}")] | ||
| ParseError { | ||
| message: String, | ||
| doc_id: String, | ||
| line_number: usize, | ||
| }, |
There was a problem hiding this comment.
Would we get this error? Technically we are parsing things, and there can be errors. But largely most errors would come from ftd.
Merged
Heulitig
added a commit
that referenced
this pull request
Sep 14, 2022
Arpita-Jaiswal
pushed a commit
that referenced
this pull request
Sep 14, 2022
* ignored grepping id for commented/escaped-out components * ignored ids under component definition * clippy fix + removed debugs * id regex adjustment * adjusted to ignore mapping ids for youtube components + refactored code * removed debugs + minor adjustments * adjustments for few more cases * using moved ftd parsing functions #1 * using moved ftd parsing functions #2 * moved ID regex to ftd and removed debugs * cargo fmt * bumped ftd version -> 7c702f9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.