Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove auth and related features
Authentication related feature and routes are removed, specifically:
auth handlers for email_password and github OAuth providers which were
working
other untested OAuth providers (discord, twitter, telegram)
Below listed processor yield an error when used, these used to provide "mixed
privacy" features which was never full implemented nor documented anywhere.
We will bring a revised version "mixed privacy" feature in future.
document-readers
user-groups
user-group-by-id
get-identities
is-reader
http::Request::ud is marked todo!(): This is a major breaking change as
we do use it in our internal codebase. There are three ways I can think of by
which we can keep this function in fastn-core:
code in here
fastn_user
table exists when FASTN_ENABLE_AUTH isset. ud() will also only work when FASTN_ENABLE_AUTH is set
this function from there.
I think we should either go with first or third option. Going with third
means that fastn does not know or care about auth at all which imo is a good
thing.
remove diesel dep