Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/rm auth #1829

Merged
merged 6 commits into from
Apr 3, 2024
Merged

feat/rm auth #1829

merged 6 commits into from
Apr 3, 2024

Conversation

siddhantk232
Copy link
Contributor

@siddhantk232 siddhantk232 commented Apr 2, 2024

remove auth and related features

Authentication related feature and routes are removed, specifically:

  • auth handlers for email_password and github OAuth providers which were
    working

  • other untested OAuth providers (discord, twitter, telegram)

  • Below listed processor yield an error when used, these used to provide "mixed
    privacy" features which was never full implemented nor documented anywhere.
    We will bring a revised version "mixed privacy" feature in future.

    • document-readers
    • user-groups
    • user-group-by-id
    • get-identities
    • is-reader
  • http::Request::ud is marked todo!(): This is a major breaking change as
    we do use it in our internal codebase. There are three ways I can think of by
    which we can keep this function in fastn-core:

    1. we use fastn-community/auth as a dependency and use a function exposed by its rust
      code in here
    2. we use tokio-postgres and assume fastn_user table exists when FASTN_ENABLE_AUTH is
      set. ud() will also only work when FASTN_ENABLE_AUTH is set
    3. we suggest everyone to use fastn-community/auth as a dependency and use
      this function from there.

    I think we should either go with first or third option. Going with third
    means that fastn does not know or care about auth at all which imo is a good
    thing.

  • remove diesel dep

Authentication related feature and routes are removed, specifically:

- auth handlers for email_password and github OAuth providers which were
  working
- other untested OAuth providers (discord, twitter, telegram)
- user-groups, readers, writers: No mixed privacy feature work now

Error messages for the processors like document-{readers, writers} have
been added

http::Request::ud is marked todo!()
@siddhantk232 siddhantk232 requested a review from amitu April 2, 2024 15:17
@amitu
Copy link
Contributor

amitu commented Apr 3, 2024

I agree with the third option. Let's try to use auth stuff at FifthTry the way we want our end customers to use it.

@amitu amitu merged commit 4d716c0 into main Apr 3, 2024
1 check passed
@amitu amitu deleted the feat/rm-auth branch April 3, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants