Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple Figure.export() #505

Closed
wants to merge 6 commits into from
Closed

simple Figure.export() #505

wants to merge 6 commits into from

Conversation

kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented May 17, 2024

Simple Figure.export() method that saves a snapshot of the renderer using imageio

closes #504

clewis7
clewis7 previously approved these changes May 31, 2024
Copy link
Member

@clewis7 clewis7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kushalkolar and others added 5 commits June 16, 2024 18:14
* just a start

* pushing to continue on my desktop

* progress on buffer manager cleanup_key

* more progress, still lots to do

* slicing working with PointsDataFeature, negative slices too, still major WIP

* comitting stuff

* _update_range() is pretty good now

* comment

* if statement

* simply colors setting

* type annotation

* simpler slice parsing

* remove cleanup_key :D :D :D git status!

* all fancy and negative indexing working :D

* start tests

* exception message

* more on tests

* refactor sizes, not tested yet

* start parameterizing buffer tests

* better buffer tests

* more variants

* add array fancy indexing to same parameterization

* parameterize tuple tests

* remove repr

* test offset and size

* test offset and size

* test create colors

* also test with direct truth indices in colors

* points tests, works

* remove imports

* sizes test working, other cleanup

* export sizes feature again

* ideas for sharing and unsharing buffers between graphics

* ideas for sharing and unsharing buffers between graphics, nto tested

* typing

* attach and detach buffers to a graphic, not tested

* import

* more int point tests

* Graphic.add_event_handler

* adding and removing data feature event works and tested

* common features, WIP

* regular features and refactor line and scatter into positions graphic

* uniform sizes

* implement sizes and uniform size for scatter

* VertexCmap feature, not yet tested

* start image features, not tested, add thickness, not tested

* better cmap parsing

* cleanup

* image features

* cleanup

* start selection feature refactor

* more on selection features

* offset and rotation for base graphic

* feature event table

* position feature event tables

* rotation and offset features

* work on selectors, WIP, linear region selector inits properly and moves for x-axis

* proper centering

* much simpliified and better linear region selector

* linear region selector works well on x axis with events and data selection

* vertex cmap fix, delete synchronizer

* linear selector works

* cleanup

* update graphic methods mixin

* update selector example nbs, still WIP

* type annotation in setter

* add notes to tests comments

* refactor image stuff

* image selector tool

* return selectors as proxies

* image stuff works

* fix offsets adding graphics, fix positions_graphic cmap bug, quickstart runs :D

* fix add_graphic args and mixin

* simpler graphic collection stuff

* more line collection

* remove old events system

* fix some examples

* remove lingering older interaction stuff

* cleanup

* fill color arg

* black

* update examples

* fix image tiling, better heatmap example

* update hm examples

* fix hlut

* refactor graphics base

* update line examples

* bug fixes

* update text to use new gfeatures

* cleanup

* implement iterator for TextureArray, much simpler now :D

* basic texture tests

* bugfix, cleanup

* image graphic tests

* type annot

* test stuff

* tests for common and visible kwarg for Graphic

* bugfix

* test remove event hanlders common fea

* rename

* start test positions graphics

* test progress

* black

* add __len__ to buffer managers, add __array_interface__ raises error

* TextureArray has len()

* docstring

* updates and tests

* black

* uniform colors tests and bug fix

* black

* bugfix uniform color and sizes

* sizes and thickness tests

* tests update

* lotta team work

* docstring, small things

* rename UniformSizes -> UniformSize

* update graphic methods mixin

* update graphic methods mixin

* bugfix

* test data slice for positiosn graphics

* test colors property within buffer tests

* cleanup

* emit user key not parsed key

* rename cmap_values to transform

* cmap_values -> cmap_transform in mixin

* test graphics in vertex data buffer manager tests

* cmap transform tests

* make Graphic._features private, add Graphic.events property

* color events tests

* move data slice test to just buffer tests

* data events tests

* cleanup

* cleanup, remove old histogram graphic

* text changes and tests

* texture array tests with graphic

* image graphic tests

* update image features

* black

* append data and world xy for graphic pointer events

* black

* move constructor to top

* example tests for wide and square hm

* update ci

* fix message

* update examples

* bugfix, docstrings

* docstrings, exception messages

* update api docs

* apparently we use __all__ in graphics to generate api docs

* remove nbsphinx

* bump version

* docstring

* finish up line collection

* fix adding line selector to line collection

* finish line collection

* update line collection examples

* graphic collections are now iterables, add examples for setting properties, add names and metadatas args, separate kwargs for collection and individual lines

* 3d line stack example with animation

* fix line collection cmap with additional args

* black

* update kwargs for line collection because of mixin

* add numpy.integer check for buffermanager parse slice

* rename

* docstrings

* line linear selector init logic

* fix line collection init selectors

* fix selector

* add plot area hook for collections

* docstring

* update selector nbs

* update example nb

* update nb

* cleanup

* update nb

* update nbs

* feature is private class attr

* fix

* remove anim example from screenshot tests

* update screenshots

* update screenshot

* update CONTRIBUTING

* smaller hm data test for CI

* exclude heatmap change data from tests, too large RAM usage probably

* black

* change dtype to save ram usage for CI

* remove large square heatmap from screenshot tests

* black

* disable all but one hm test

* fix gc

* update screenshots

* replace one more test image

* fix docs

* update image screenshots

* fix docs

* docstrings, Graphic.events -> Graphic.supported_events

* update docs

---------

Co-authored-by: Caitlin <caitlin9165@gmail.com>
clewis7
clewis7 previously approved these changes Jun 16, 2024
@kushalkolar kushalkolar dismissed clewis7’s stale review June 16, 2024 23:33

The merge-base changed after approval.

clewis7
clewis7 previously approved these changes Jun 17, 2024
@kushalkolar kushalkolar dismissed clewis7’s stale review June 17, 2024 00:34

The merge-base changed after approval.

clewis7
clewis7 previously approved these changes Jun 18, 2024
Copy link
Member

@clewis7 clewis7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushalkolar kushalkolar dismissed clewis7’s stale review June 18, 2024 20:59

The merge-base changed after approval.

@kushalkolar
Copy link
Member Author

idk why this is being weird, going to do a new PR

@kushalkolar kushalkolar deleted the export branch June 18, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure.export() ?
2 participants