Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
We can run the next Rails version in Heroku
IMPORTANT NOTES:
How are we going to manage this change in the long term? When the people at Heroku release new changes we are going to miss them out, is it better to keep our changes in a branch and rebase their changes as time passes? For sure, it would be better if we propose these changes to the official build pack and get merged 🤞
Switching between the current and next Rails versions in the same Heroku instance is not straightforward, we should run a purge or clean command to remove previously used gems and not fall on an issue. But why do we need to switch between them? is that our main reason for supporting Gemfile.next? I don't think so.
Even without these changes some tests were failing locally, it might be because of a misconfiguration, I wonder if we should make those tests pass and add more tests with the new implementation.
QA NOTES:
Select a project that already has the dual-boot configured and running.
In Heroku, go to the settings
![image](https://private-user-images.githubusercontent.com/7331511/315618652-e5f63710-10b7-4c53-8ed5-60b4e98afafc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2Nzk0MDYsIm5iZiI6MTcyNTY3OTEwNiwicGF0aCI6Ii83MzMxNTExLzMxNTYxODY1Mi1lNWY2MzcxMC0xMGI3LTRjNTMtOGVkNS02MGI0ZTk4YWZhZmMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDdUMDMxODI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGJkNGUyZmJlOWFhNDE0NTNhZmE4MWQ5MzhmMjcyNmNiNmUzZTNiMGY5YjZhZjk0NDZiYjcxMTQ0ZDc5YjEwYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.0T27c-GW3InoiGUUBauhDxtey7RSnQIFDtIFKtEkU7o)
Remove the official
heroku/ruby
build pack and include our build packhttps://github.com/fastruby/heroku-buildpack-ruby#add_gemfile_next_support
Notice that right now we are using this branch to test the changes.
BUNDLE_GEMFILE
as a key andGemfile.next
as a value, then click add.Make sure Heroku picks the value you set in the config vars sometimes this takes some time.
heroku run bash --app your_app_name
to get into the bash in Heroku.then run the
rails --version
,rails console
,echo $BUNDLE_GEMFILE
or any other command that helps you know you are using the next Rails version.