Add Setting for --include-checks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property has no effect, and its removal silences the following warning: WARNING: cfnlint: Defining 'cls.executable' has no effect. Please cleanup and remove this setting.
Previously we used self.get_view_settings(), which has been deprecated. Moving to using self.settings directly silences this warning: WARNING: cfnlint: `self.get_view_settings()` has been deprecated. Just use the member `self.settings` which is the same thing.
These checks we're added in v0.8.0, they warn about best practices.
|
Thanx for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
include_checksarray setting that corresponds to the--include-checksCLI option. This allows you to enable the information checks — which are disabled by default.I also cleaned up 2 different warnings being emitted by the ST console:
cls.executableproperty, as it has no effect.self.settingsdirectly instead of callingself.get_view_settings().