Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Setting for --include-checks #1

Merged
merged 5 commits into from
Nov 25, 2019
Merged

Add Setting for --include-checks #1

merged 5 commits into from
Nov 25, 2019

Commits on Nov 20, 2019

  1. Remove cls.executable 

    This property has no effect, and its removal silences the following
warning:

WARNING: cfnlint: Defining 'cls.executable' has no effect. Please
cleanup and remove this setting.
    @patrickrgaffney
    patrickrgaffney committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    3a03e11 View commit details
    Browse the repository at this point in the history

  2. Update how the linter setttings are fetched 

    Previously we used self.get_view_settings(), which has been deprecated.
Moving to using self.settings directly silences this warning:

WARNING: cfnlint: `self.get_view_settings()` has been deprecated.
Just use the member `self.settings` which is the same thing.
    @patrickrgaffney
    patrickrgaffney committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    ad7d289 View commit details
    Browse the repository at this point in the history

  3. Allow for "informational" checks 

    These checks we're added in v0.8.0, they warn about best practices.
    @patrickrgaffney
    patrickrgaffney committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    08eae22 View commit details
    Browse the repository at this point in the history

  4. Update README with include_checks setting

    @patrickrgaffney
    patrickrgaffney committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    f54bfbb View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2019

  1. Create the regex over multiple lines for readability

    @patrickrgaffney
    patrickrgaffney committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    2649a28 View commit details
    Browse the repository at this point in the history