Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added queue.task_done() #21

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Added queue.task_done() #21

merged 1 commit into from
Apr 14, 2018

Conversation

geekscrapy
Copy link

@geekscrapy geekscrapy commented Apr 14, 2018

Added so I can wait for tasks to finish before issuing a browser.close_tab(tab)

@codecov
Copy link

codecov bot commented Apr 14, 2018

Codecov Report

Merging #21 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   92.85%   92.89%   +0.03%     
==========================================
  Files           4        4              
  Lines         210      211       +1     
  Branches       21       21              
==========================================
+ Hits          195      196       +1     
  Misses          7        7              
  Partials        8        8
Impacted Files Coverage Δ
pychrome/tab.py 90.78% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 181cd5c...da71fad. Read the comment docs.

@fate0 fate0 merged commit 3265932 into fate0:master Apr 14, 2018
@fate0
Copy link
Owner

fate0 commented Apr 14, 2018

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants