Reduced column sizes in taggings table migration. #187

Closed
wants to merge 16 commits into
from

3 participants

@HuckyDucky

... facilitate index creation on MySQL databases with a default storage engine of MyISAM.

@HuckyDucky HuckyDucky Reduced text columns in taggings from 255 characters to 50 characters…
… to facilitate index creation on MySQL databases with a default storage engine of MyISAM.
d00214f
@travisbot

This pull request fails (merged d00214f into 69cfd33).

@travisbot

This pull request passes (merged 80210b3 into 69cfd33).

@travisbot

This pull request fails (merged 9e44469 into 69cfd33).

@travisbot

This pull request fails (merged 0757c04 into 69cfd33).

@travisbot

This pull request fails (merged 36a5036 into 69cfd33).

@travisbot

This pull request fails (merged 054f3df into 69cfd33).

@travisbot

This pull request fails (merged 94209aa into 69cfd33).

@travisbot

This pull request fails (merged 2ba9422 into 69cfd33).

@travisbot

This pull request fails (merged ce23bc7 into 69cfd33).

@travisbot

This pull request fails (merged 3d1d281 into 69cfd33).

@steveyken
Fat Free CRM member

Thanks for this. It's heading in the right direction. We also need to add support for custom fields whitelisting too. I believe setting config.active_record.whitelist_attributes = false for now should work around the issue but I wholeheartedly agree with actually fixing the problem rather than working around it!

@steveyken
Fat Free CRM member

Thanks for your work on this. I've added commit d00214f to master. This will ensure mysql / MyISAM setups will migrate from scratch. Will leave attr_accessible for another day so leaving this pull request open.

@steveyken
Fat Free CRM member

This is the gem that provides autocomplete-rails: https://github.com/crowdint/rails3-jquery-autocomplete

Fat Free CRM member

Sorry, ignore previous comment. I've just read 36a5036

@steveyken
Fat Free CRM member

Thanks for this. Just going through the pull-requests. For my reference, this commit was cherry-picked into master a while ago.

@steveyken
Fat Free CRM member

This is the gem that provides autocomplete-rails: https://github.com/crowdint/rails3-jquery-autocomplete

Fat Free CRM member

Sorry, ignore previous comment. I've just read 36a5036

@steveyken
Fat Free CRM member

I've pulled the attr_accessible commits out into a new branch called 'attr_accessible' in FFCRM. I'll close this pull-request now and we can focus on that branch for the remaining attr_accessible features.

@steveyken steveyken closed this Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment