Reduced column sizes in taggings table migration. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to facilitate index creation on MySQL databases with a default storage engine of MyISAM.
…piece of code that does not actually exist.
…e-added autocomplete lines in application.js and leads controller
…assignment errors
|
Thanks for this. It's heading in the right direction. We also need to add support for custom fields whitelisting too. I believe setting config.active_record.whitelist_attributes = false for now should work around the issue but I wholeheartedly agree with actually fixing the problem rather than working around it! |
|
Thanks for your work on this. I've added commit d00214f to master. This will ensure mysql / MyISAM setups will migrate from scratch. Will leave attr_accessible for another day so leaving this pull request open. |
|
I've pulled the attr_accessible commits out into a new branch called 'attr_accessible' in FFCRM. I'll close this pull-request now and we can focus on that branch for the remaining attr_accessible features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... facilitate index creation on MySQL databases with a default storage engine of MyISAM.