Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback Extension - Updated #23

Closed
wants to merge 2 commits into from
Closed

Callback Extension - Updated #23

wants to merge 2 commits into from

Conversation

ndbroadbent
Copy link
Contributor

Hi Michael,

I've refactored and updated the callback extension, and have fixed the limitation I was mentioning before, where a hook cannot be modified multiple times. I'll let the commit message speak for itself:

  • Heavily refactored and reworked callback extension. View hooks are now treated as a separate entity, distinct from controller and legacy view hooks. However, they both still use the same @@responder variable to store the classes that implement a given hook. View hooks are now stored as Procs in a hash instead of being defined as methods on the class. This allows a Callback subclass to chain data operations for the same hook.
  • Improved documentation and tidied up code.
  • Added specs for chaining view hook operations, created new CallbackSpecHelper module to contain helper classes and methods.

Thanks,
Nathan

…en content can be appended or prepended, or replace or remove the block entirely. Is fully backwards compatible with existing view hooks
…now treated as a separate entity, distinct from controller and legacy view hooks. However, they both still use the same @@responder variable to store the classes that implement a given hook. View hooks are now stored as Procs in a hash instead of being defined as methods on the class. This allows a Callback subclass to chain data operations for the same hook.   * Improved documentation and tidied up code.   * Added specs for chaining view hook operations, created new CallbackSpecHelper module to contain helper classes and methods.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant