Fix security issues #749
Merged
Fix security issues #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloCkWeRX
reviewed
Feb 1, 2018
| if find | ||
| find.safe_constantize | ||
| else | ||
| raise "Unknown resourse" |
CloCkWeRX
reviewed
Feb 1, 2018
| @@ -114,7 +114,22 @@ def subform | |||
| protected | |||
|
|
|||
| def field_params | |||
| params[:field].permit! | |||
| params.require(:field).permit( | |||
There was a problem hiding this comment.
I doubt that anyone would have extended the field class while using it as an engine; but we should make sure we write a migration guide for anywhere we went for explicit param whitelisting, suggesting people will want to .permit() their customised attributes
|
and rubocop --auto-gen-config too |
|
@DmitryAvramec there's still a rubocop error here. |
DmitryAvramec
force-pushed
the
sec-fix
branch
from
b3a29b2
to
2fd5aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.