Make all package modules private #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modules inside the package are mostly a way for us to organize code. Users are meant to use things from the top-level namespace which we define in `boule/__init__.py`. To avoid confusion and the modules showing up in tab-completion, make them all private by adding a leading `_`.
|
Merging this in since it's an internal change that ideally shouldn't impact users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The modules inside the package are mostly a way for us to organize code.
Users are meant to use things from the top-level namespace which we
define in
boule/__init__.py. To avoid confusion and the modulesshowing up in tab-completion, make them all private by adding a leading
_.Relevant issues/PRs