Add missing attributes for pymap3 compatibility #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our Ellipsoid class was almost fully compatible the coordinate conversion functions in pymap3d. The only things missing between our ellipsoid and theirs was the `eccentricity` and `thirdflattening` attributes. Added these and a few tests to check that the integration works.
This was referenced Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our Ellipsoid class was almost fully compatible the coordinate
conversion functions in pymap3d. The only things missing between our
ellipsoid and theirs was the
eccentricityandthirdflatteningattributes. Added these and a few tests to check that the integration
works.
Relevant issues/PRs
Fixes #114