-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ellipsoids #180
New ellipsoids #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! I pushed some minor fixes to the citations and renamed the Vesta triaxial to VestaTriaxial2017
to keep the CamelCase notation.
I think this is fine. The API itself is only 3 classes so having all of these in the main namespace is OK. |
The PR makes the following changes:
comments
attribute to all ellipsoid classes that is used when instantiating the ellipsoid classes. The default value is None. This attribute can provide additional information for understanding the origin of the numbers used to instantiate the class (for example, many papers provide several different versions of the ellipsoid, and you need to choose one).semimajor_axis_longitude
as an optional attribute that is used to instantiate triaxial ellipsoids. Previously, this parameter was found as an optional argument to thegeocentric radius
function. However, this parameter is an intrinsic property of the ellipsoid and the coordinate frame, and will be necessary for all routines that make use of longitude coordinates. Thetest_geocentric_radius_semimajor_axis_longitude
was somewhat modified: I declared a new ellipsoidtriaxialellipsoid_90
that setsemimajor_axis_longitude
to 90.boule.ellipsoids
. I will wait for your comments before doing so. Note that the ellipsoid year corresponds to the year when all the required data were published, or to the year that we assembled the ellipsoid ourselves using various sources.Vesta Notes
I removed the original VESTA triaxial ellipsoid because there is not enough information in the paper to determine the GM, it is not stated if the ellipsoid is geocentric or offset from the center of mass, and the directions of the principal axes are not given. I think that keeping this ellipsoid as is will just cause problems for people who use it. I wasted a lot of time trying to figure this one out (and never did). Instead, two new ellipsoids have been added: The default (Vesta2017) is biaxial, as Vesta has no real tides. The Vesta2017_triaxial ellispoid, in contrast, is triaxial. The triaxial one, however, is not aligned with the topography and gravity coordinate axes, and this is specified by the new attribute
semimajor_axis_longitude
.All Ellipsoids
Mercury
Venus
Earth
Moon
Asteroids
Mars
Jupiter system
Saturn system
Pluto system
Relevant issues/PRs:
Closes #176