Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mercury and moon spheres to realizations.py #71

Merged
merged 9 commits into from
Nov 10, 2020

Conversation

dabiged
Copy link
Contributor

@dabiged dabiged commented Nov 10, 2020

Added Mercury and Moon Spheroids, plus documentation.
This completes #53 .

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

@leouieda
Copy link
Member

@dabiged thanks for this! I made a few minor fixes to the docs formatting. The pages were missing from doc/ellipsoids/index.rst and I forgot about it in the previous PR as well. When CIs finish, I'd be happy to merge this.

@leouieda leouieda merged commit 294e898 into fatiando:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants