This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Fixed bug in PointGrid mesh ordering #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grid was mixing up x (North-South, rows) with y (East-West, columns). This is a legacy bug that was fixed in gridder.regular but didn't propagate the PointGrid because it wasn't using "regular" to generate its grid. It now uses (also avoids duplicate code) and fixes the order. Had to fix the Bk matrix in the PEL equivalent layer as well.
leouieda
added a commit
that referenced
this pull request
Jul 8, 2015
Fixed bug in PointGrid mesh ordering
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grid was mixing up x (North-South, rows) with y (East-West, columns). This is a legacy bug that was fixed in gridder.regular ( #196) but didn't propagate the PointGrid because it wasn't using "regular" to generate its grid. It now uses (also avoids duplicate code) and fixes the order. Had to fix the Bk matrix in the PEL equivalent layer as well.
Checklist:
doc/contributors.rst(leave for last)