New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in PointGrid mesh ordering #209

Merged
merged 6 commits into from Jul 8, 2015

Conversation

Projects
None yet
1 participant
@leouieda
Member

leouieda commented Jul 6, 2015

The grid was mixing up x (North-South, rows) with y (East-West, columns). This is a legacy bug that was fixed in gridder.regular ( #196) but didn't propagate the PointGrid because it wasn't using "regular" to generate its grid. It now uses (also avoids duplicate code) and fixes the order. Had to fix the Bk matrix in the PEL equivalent layer as well.

Checklist:

  • Make tests for new code
  • Create/update docstrings
  • Include relevant equations and citations in docstrings
  • Code follows PEP8 style conventions
  • Code and docs have been spellchecked
  • Include new dependencies in docs, requirements.txt, README, and .travis.yml
  • Documentation builds properly
  • All tests pass
  • Can be merged
  • Changelog entry (leave for last)
  • Firt-time contributor? Add yourself to doc/contributors.rst (leave for last)
Fixed bug in PointGrid mesh ordering
The grid was mixing up x (North-South, rows) with y (East-West,
columns). This is a legacy bug that was fixed in gridder.regular but
didn't propagate the PointGrid because it wasn't using "regular" to
generate its grid. It now uses (also avoids duplicate code) and fixes
the order. Had to fix the Bk matrix in the PEL equivalent layer as well.

@leouieda leouieda added this to the 0.4 milestone Jul 6, 2015

@leouieda leouieda removed the maintenance label Jul 8, 2015

leouieda added a commit that referenced this pull request Jul 8, 2015

Merge pull request #209 from fatiando/pointgrid_bug
Fixed bug in PointGrid mesh ordering

@leouieda leouieda merged commit 3455514 into master Jul 8, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@leouieda leouieda deleted the pointgrid_bug branch Jul 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment