New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching over to setuptools #294

Merged
merged 2 commits into from Jul 14, 2016

Conversation

Projects
None yet
1 participant
@leouieda
Member

leouieda commented Jul 13, 2016

The Python Packaging Guide recommends using setuptools instead of distutils in setup.py.

This is a one line replacement and adds the advantage of the find_packages function (use it instead of having to list all subpackages in Fatiando by hand).

Checklist:

  • Make tests for new code (at least 80% coverage)
  • Create/update docstrings
  • Include relevant equations and citations in docstrings
  • Docstrings follow the style conventions
  • Code follows PEP8 style conventions
  • Code and docs have been spellchecked
  • Include new dependencies in doc/install.rst, requirements.txt, environment.yml, ci/requirements-conda.txt and ci/requirements-pip.txt.
  • Documentation builds properly (run cd doc; make locally)
  • Changelog entry (leave for last to avoid conflicts)

@leouieda leouieda added this to the 0.5 milestone Jul 13, 2016

@leouieda leouieda force-pushed the use-setuptools branch from 4dc3538 to 08cdee6 Jul 13, 2016

@leouieda leouieda force-pushed the use-setuptools branch from 060e5e2 to cf5ea1d Jul 14, 2016

@leouieda leouieda merged commit 03810c3 into master Jul 14, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 72.505%
Details

@leouieda leouieda deleted the use-setuptools branch Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment