Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interger values in sample grids should be converted to float #30

Closed
leouieda opened this issue Nov 29, 2018 · 0 comments
Closed

Interger values in sample grids should be converted to float #30

leouieda opened this issue Nov 29, 2018 · 0 comments
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)
Milestone
v0.1.0

Comments

@leouieda
Copy link
Member

Description of the desired feature

The height in our sample gravity and topography are stored as integers to save space. However, this can cause problems in computations involving division. To avoid having to explain this to users or add warnings, we should convert these data types to float32 in the fetch_* functions once they are loaded.
@leouieda leouieda added enhancement Idea or request for a new feature help wanted good first issue Good for newcomers (doesn’t require deep knowledge of the project) labels Nov 29, 2018
@leouieda leouieda added this to the v0.1.0 milestone Dec 4, 2018
leouieda added a commit that referenced this issue Dec 13, 2018
@leouieda
Use original ETOPO1 heights and cast ints to float
a54520d 
ETOPO1 is referenced to sea level. I had used a geoid model to convert
it to geometric heights but this is not a great idea. Revert back to the
original. The data were stored as ints to save space but this can cause
problems with divisions and other operations. Cast them back to float
after loading with our functions.

Fixes #29
Fixes #30
@leouieda leouieda mentioned this issue Dec 13, 2018
Merged
leouieda added a commit that referenced this issue Dec 14, 2018
@leouieda
Use original ETOPO1 heights and cast ints to float (#32)
d83fe92 
ETOPO1 is referenced to sea level. I had used a geoid model to convert
it to geometric heights but this is not a great idea. Revert back to the
original. The data were stored as ints to save space but this can cause
problems with divisions and other operations. Cast them back to float
after loading with our functions.

Fixes #29
Fixes #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
1 participant
@leouieda