-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Pooch class to make it easily subclassed #27
Comments
Would be great to have an easier access to the filenames inside the registry. For example, if we want to get a list of every filename in the registry we must do something like this:
Would be nice to have a more stylish way of doing it, something like |
@santisoler OK, that's something we could easily add as a |
Thanks! Merged |
Refactor the actual HTTP download into a "downloader" class. Allow custom downloaders to be passed to `Pooch.fetch`. The advantage of this over subclassing `Pooch` is that it requires less effort from users. We can also provide a collection of ready-made downloader classes. For now, we have `HTTPDownloader` which can be used to pass credentials to the server. Fixes #65 Fixes #27
From @remram44 comment on #4, it would be great to expose more of the inner workings of the
Pooch
class as methods. This would make it easy to subclass it and overwrite those methods. The_download_file
method should also be made public (remove the leading_
).Any ideas and suggestions on what should be refactored are welcome.
The text was updated successfully, but these errors were encountered: