Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FTP downloader #118

Merged
merged 42 commits into from Nov 19, 2019
Merged

Add FTP downloader #118

merged 42 commits into from Nov 19, 2019

Commits on Nov 5, 2019

  1. Add FTP Downloader

    @andersy005
    andersy005 committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    9ffa90e View commit details
    Browse the repository at this point in the history

  2. Formatting only

    @andersy005
    andersy005 committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    cd56a54 View commit details
    Browse the repository at this point in the history

  3. Fix styling issues

    @andersy005
    andersy005 committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    4f370e6 View commit details
    Browse the repository at this point in the history

  4. Remove whitespace

    @andersy005
    andersy005 committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    96e3c79 View commit details
    Browse the repository at this point in the history

  5. Fix styling issue

    @andersy005
    andersy005 committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    a32f0e7 View commit details
    Browse the repository at this point in the history

  6. Refactor FTPDownloader

    @andersy005
    andersy005 committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    180825c View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. Add test for FTP downloader

    @andersy005
    andersy005 committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    be24247 View commit details
    Browse the repository at this point in the history

  2. Add FTPDownloader to doc

    @andersy005
    andersy005 committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    73109a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Use ftplib module instead of requests-ftp

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    446dc81 View commit details
    Browse the repository at this point in the history

  2. Update ftp_downloader test

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    37957a6 View commit details
    Browse the repository at this point in the history

  3. Update docstring

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    2dcc4de View commit details
    Browse the repository at this point in the history

  4. Remove f-string for Python3.5 compatibility

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    9f86c8b View commit details
    Browse the repository at this point in the history

  5. Raise Error when the protocol is not supported

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    d5a577c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:fatiando/pooch into ftp-downloader

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    317e637 View commit details
    Browse the repository at this point in the history

  7. Update permission_error test

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    8787366 View commit details
    Browse the repository at this point in the history

  8. Update availability test

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    4cf3c9b View commit details
    Browse the repository at this point in the history

  9. Formatting only

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    b1a5fbb View commit details
    Browse the repository at this point in the history

  10. Add test for unsupported protocol

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    ac3dca7 View commit details
    Browse the repository at this point in the history

  11. Attempt at fixing doctest error

    @andersy005
    andersy005 committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    5ba9f63 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2019

  1. Address doctest dictionary issue

    @andersy005
    andersy005 committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    e0384c2 View commit details
    Browse the repository at this point in the history

  2. Skip permission_error test on windows

    @andersy005
    andersy005 committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    9e138ac View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. Use pathlib

    @andersy005
    andersy005 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    a27751e View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Skip ftp tests on TravisCI

    @andersy005
    andersy005 committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    066a891 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Fix test

    @andersy005
    andersy005 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    8c92a34 View commit details
    Browse the repository at this point in the history

  2. Fix linting issue

    @andersy005
    andersy005 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    8c27187 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:fatiando/pooch into ftp-downloader

    @andersy005
    andersy005 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    f914d95 View commit details
    Browse the repository at this point in the history

  4. Update pooch/tests/test_core.py 

    Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
    @andersy005 @leouieda
    andersy005 and leouieda committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    9cab0fa View commit details
    Browse the repository at this point in the history

  5. Update pooch/downloaders.py 

    Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
    @andersy005 @leouieda
    andersy005 and leouieda committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    843c92b View commit details
    Browse the repository at this point in the history

  6. Update pooch/tests/test_core.py 

    Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
    @andersy005 @leouieda
    andersy005 and leouieda committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    d683c3f View commit details
    Browse the repository at this point in the history

  7. Update pooch/tests/test_core.py 

    Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
    @andersy005 @leouieda
    andersy005 and leouieda committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    67d11a0 View commit details
    Browse the repository at this point in the history

  8. Update pooch/tests/test_core.py 

    Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
    @andersy005 @leouieda
    andersy005 and leouieda committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    bf440a9 View commit details
    Browse the repository at this point in the history

  9. formatting only

    @andersy005
    andersy005 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    acdf4c1 View commit details
    Browse the repository at this point in the history

  10. Put old test back and clean up FTPDowloader

    @andersy005
    andersy005 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7405bc3 View commit details
    Browse the repository at this point in the history

  11. Remove optional from docstring

    @andersy005
    andersy005 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    4bd86d9 View commit details
    Browse the repository at this point in the history

  12. Use try block to make sure connection is closed

    @andersy005
    andersy005 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    f4b538c View commit details
    Browse the repository at this point in the history

  13. Update docstring

    @andersy005
    andersy005 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    b42d13a View commit details
    Browse the repository at this point in the history

  14. Update docstring

    @andersy005
    andersy005 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    c07ef8e View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Merge branch 'master' into ftp-downloader

    @leouieda
    leouieda committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    cb3338f View commit details
    Browse the repository at this point in the history

  2. Add progressbar test for FTP

    @leouieda
    leouieda committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    6c06e6d View commit details
    Browse the repository at this point in the history

  3. Simplify is_available

    @leouieda
    leouieda committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    1d69cc6 View commit details
    Browse the repository at this point in the history

  4. Refactor FTPDownloader to make it simpler and safer 

    Add the try: except: block to close connections and the output file in
case of exceptions. Use the same defaults for credentials as ftplib.
    @leouieda
    leouieda committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    50e92d2 View commit details
    Browse the repository at this point in the history

  5. Add FTP section to usage docs

    @leouieda
    leouieda committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    193604e View commit details
    Browse the repository at this point in the history