Port from deprecated appdirs to platformdirs #339
Conversation
|
💖 Thank you for opening your first pull request in this repository! 💖 A few things to keep in mind:
⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐ |
| @@ -41,7 +41,7 @@ packages = find: | |||
| python_requires = >=3.7 | |||
| setup_requires = | |||
| install_requires = | |||
| appdirs>=1.3.0 | |||
| platformdirs>=2.5.0 | |||
There was a problem hiding this comment.
Is this min version ok? 2.5.0 was released a year ago, but older versions should work as well. This seems to be the bigger release:
https://github.com/platformdirs/platformdirs/releases/tag/2.1.0
|
Thanks @alexfikl for opening this PR! Very much appreciated! I think this is ready to be merged. Regarding the minimum version of |
|
🎉 Congrats on merging your first pull request and welcome to the team! 🎉 If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved. |
This ports the uses (and mentions) of the deprecated
appdirstoplatformdirs. The APIs should be mostly equivalent (definitely for the ones used here) andplatformdirsis already in use by most popular projects.