Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for new zenodo API #372

Closed
wants to merge 1 commit into from
Closed

Fix for new zenodo API #372

wants to merge 1 commit into from

Conversation

ericpre
Copy link

@ericpre ericpre commented Oct 17, 2023

Fixes #371. I find the new key by inspecting the response, not from a blessed official documentation... but it works...

Relevant issues/PRs:

Example:

import pooch

_GOSH_DOI = "10.5281/zenodo.7645765"
_GOSH_URL = f"doi:{_GOSH_DOI}/Segger_Guzzinati_Kohl_1.5.0.gosh"
_GOSH_KNOWN_HASH = "md5:7fee8891c147a4f769668403b54c529b"

gos_file_path = pooch.retrieve(
    url=_GOSH_URL,
    known_hash=_GOSH_KNOWN_HASH,
    progressbar=True,
)

@welcome
Copy link

welcome bot commented Oct 17, 2023

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

No matter what, we are really grateful that you put in the effort to do this!

@santisoler
Copy link
Member

Hi @ericpre! Thanks a lot for opening this PR. Apparently we were working on the same bugfix at the same time haha: #373

In that PR I made the same change for getting the list of files available in the repository, but also changed how the download url is built, and also fixed the registry population from the doi.

Since you're interested in solving the same issue, would you mind taking a look at that PR and provide some review? We can continue your work over.

@ericpre
Copy link
Author

ericpre commented Oct 17, 2023

Closing in favour of #373.

@ericpre ericpre closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'key' in ZenodoRepository.download_url() after Zenodo migration
2 participants