Allow block_reduce to take a weights argument #50
Labels
enhancement
Idea or request for a new feature
Comments
leouieda
added a commit
that referenced
this issue
May 24, 2018
`BlockReduce` now accepts multiple data components and weights. Weights will only work if the reduction function accepts a `weights` keyword argument. Separate the coordinate calculation into a private method for reuse when making specialized classes, like `BlockMean`. These classes will be necessary to output weights as well. There is no generic solution for that because each reduction will have a different way of estimating weights. Fixes #50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, only the data gets passed to the reducer function. If we want to do a weighted average, there is currently no way to have the windowing select the weights as well. To overcome this,
block_reducecan take an optionalweights=arrayargument. If it's given, then select the values from it as well and pass it asweights=windowed_arrayto the reducer function.The text was updated successfully, but these errors were encountered: