Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoring parameter for SplineCV #380

Merged
merged 4 commits into from Sep 7, 2022

Conversation

JamesSample
Copy link
Contributor

I've added scoring as an additional parameter in SplineCV to control the scoring metric used during cross-validation. I've also added a simple test to test_spline.py, which checks that results from SplineCV using the new scoring parameter match those from standard Spline combined with cross_val_score. I'm not sure I've put this test in the right place - please let me know if it should be elsewhere.

Relevant issues/PRs:

(Hopefully) fixes #379 (see also the discussion here).

@welcome
Copy link

welcome bot commented Sep 2, 2022

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

No matter what, we are really grateful that you put in the effort to do this!

Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this! Made a few minor suggestions and a question at the end about the test. Otherwise, this looks very good to me. Just waiting for the CI to finish running tests and checks to see if there is anything else that needs addressing.

verde/spline.py Outdated Show resolved Hide resolved
verde/tests/test_spline.py Outdated Show resolved Hide resolved
verde/tests/test_spline.py Outdated Show resolved Hide resolved
JamesSample and others added 3 commits September 6, 2022 12:23
Co-authored-by: Leonardo Uieda <leouieda@gmail.com>
Co-authored-by: Leonardo Uieda <leouieda@gmail.com>
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Merging this in 🚀

@leouieda leouieda merged commit 5d9885f into fatiando:main Sep 7, 2022
@welcome
Copy link

welcome bot commented Sep 7, 2022

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@leouieda
Copy link
Member

leouieda commented Sep 7, 2022

@JamesSample please see above ☝🏾 about adding yourself as an author 🙂 Thanks for taking the time to report and implement this!

@JamesSample JamesSample deleted the spline-cv-scoring branch September 7, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a 'scoring' argument to SplineCV
2 participants