This repository has been archived by the owner on Jul 22, 2018. It is now read-only.
add MarkUnreusable to pooled connection #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it possible to discard unreusable connections
|
@collinmsn is might read easier as: conn.MarkAsDead()Or: conn.MarkUnusable() |
|
OK, I prefer Unusable. |
| return p.c.put(p.Conn) | ||
| } | ||
|
|
||
| // MarkUnreusable() marks the connection is not reusable. |
There was a problem hiding this comment.
Comment needs to be updated too. Also can you extend the comment to let the user know that the connection will be not put into the pool anymore?
|
Unusable is better yeah, thanks for changing it. |
update comment
fatih
added a commit
that referenced
this pull request
Mar 25, 2015
add MarkUnreusable to pooled connection
|
Thanks @collinmsn 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's desirable to close the connection directly because an error, for example timeout, occurred on the connection.
conn, err := pool.Get()
defer conn.Close()
if err := UseConn(conn); err != nil {
conn.MarkUnreusable()
}
This patch adds this feature.