Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude iota and nil from goBoolean #1030

Merged
merged 2 commits into from
Sep 4, 2016
Merged

Exclude iota and nil from goBoolean #1030

merged 2 commits into from
Sep 4, 2016

Conversation

yyoshiki41
Copy link
Contributor

@yyoshiki41 yyoshiki41 commented Aug 27, 2016 •
edited
Loading

exclude iota and nil from goBoolean
It would be better to treat them separately.

Before

before

After

after

Thanks!

This change is Reviewable

@yyoshiki41 yyoshiki41 changed the title exclude iota and nil from goBoolean exclude iota and nil from goBoolean Aug 27, 2016
@yyoshiki41 yyoshiki41 changed the title exclude iota and nil from goBoolean Exclude iota and nil from goBoolean Aug 27, 2016
nhooyr
nhooyr reviewed Aug 27, 2016
View reviewed changes
syntax/go.vim
@@ -127,9 +127,11 @@ hi def link goComplexes Type
" Predefined functions and values
syn match goBuiltins /\<\v(append|cap|close|complex|copy|delete|imag|len)\ze\(/
syn match goBuiltins /\<\v(make|new|panic|print|println|real|recover)\ze\(/
syn keyword goBoolean iota true false nil
syn keyword goPredefinedVars nil, iota
Copy link
Contributor

@nhooyr nhooyr Aug 27, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goPredefinedVars should be renamed to goPredeclaredIdentifiers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

d623109

@fatih fatih merged commit 8d63566 into fatih:master Sep 4, 2016
@fatih
Copy link
Owner

fatih commented Sep 4, 2016

Thanks @yyoshiki41, this looks great 👍

@yyoshiki41 yyoshiki41 deleted the follow/gospec branch September 4, 2016 15:06
@yyoshiki41 yyoshiki41 mentioned this pull request Sep 5, 2016
Merged
@arp242
Copy link
Contributor

arp242 commented Sep 13, 2016 •
edited
Loading

I can't say I like this change. Suddenly my nil has a different colour from everything else. There is no reason it has to, I think. I find it distracting.

For those looking to fix this:

:highlight link goPredefinedIdentifiers goBoolean

@nhooyr
Copy link
Contributor

nhooyr commented Sep 13, 2016 •
edited
Loading

I think we should just link goPredefinedIdentifiers to goBoolean by default.

@fatih
Copy link
Owner

fatih commented Sep 14, 2016

@Carpetsmoker to be honest I didn't like it either. Maybe we should add it as another flag (just like we do with others). I'm open to merge a PR that put's it behind flag.

@nhooyr
Copy link
Contributor

nhooyr commented Sep 14, 2016

@fatih why do we need a flag? Just do highlight link goPredefinedIdentifiers goBoolean by default. If anyone wants a different color they can.

@fatih
Copy link
Owner

fatih commented Sep 14, 2016

@nhooyr oh I got what you mean. Mind adding a PR now? If not I'll can do it later.

@nhooyr
Copy link
Contributor

nhooyr commented Sep 14, 2016 •
edited
Loading

Can't, in class :(

edit: ok, class over, making it.

@arp242 arp242 mentioned this pull request Apr 11, 2018
Closed
@arp242 arp242 mentioned this pull request Sep 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yyoshiki41 @fatih @arp242 @nhooyr