Fix filepaths in the quickfix list for :GoVet #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `go vet` command would be run with `go#tool#ExecuteInDir()`, which translates to `cd dir && go vet`. The problem with this is that if I have `subpkg/file.go` open, the filename that `go vet` reports will be `file.go`, rather than `subpkg/file.go`. As a result, the filepath set in the quickfix or location list is also wrong and jumping to this error will jump to a new (usually non-existing) buffer. Fix it by explicitly passing the package path, rather than changing the cwd. Fixes #1376
|
Thanks @Carpetsmoker |
jeromenerf
added a commit
to jeromenerf/vim-go
that referenced
this pull request
Aug 9, 2017
Pretty much the same as fatih#1381
This was referenced Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go vetcommand would be run withgo#tool#ExecuteInDir(), whichtranslates to
cd dir && go vet.The problem with this is that if I have
subpkg/file.goopen, the filename thatgo vetreports will befile.go, rather thansubpkg/file.go. As a result,the filepath set in the quickfix or location list is also wrong and jumping to
this error will jump to a new (usually non-existing) buffer.
Fix it by explicitly passing the package path, rather than changing the cwd.
Fixes #1376