Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:GoVet uses local path for the quickfix list #2881

Closed
Aludirk opened this issue May 8, 2020 · 1 comment · Fixed by #2882
Closed

:GoVet uses local path for the quickfix list #2881

Aludirk opened this issue May 8, 2020 · 1 comment · Fixed by #2882
Labels

Comments

@Aludirk
Copy link

Aludirk commented May 8, 2020

What did you do? (required: The issue will be closed when not provided)

Run :GoVet command

What did you expect to happen?

Show correct path in quickfix list after running :GoVet command.

What happened instead?

The quickfix list shows the wrong path for :GoVet just exactly like #1376

This problem is fixed at #1381, but I found that at #2727, it seems that in lint.vim#200 is intended to change

- let [l:out, l:err] = go#util#Exec(l:cmd)
+ let [l:out, l:err] = go#util#ExecInDir(l:cmd)

at commit 936c7c3

Anyway, I fixed the problem when I just simply revert the change back in this line. I'm not sure whether this will break your intention.

Configuration (MUST fill this out):

vim-go version:

vim-go @ 620d285

vimrc you used to reproduce:

vimrc
# just use default setting

Vim version (first three lines from :version):

NVIM v0.4.3
Build type: Release
LuaJIT 2.0.5

Go version (go version):

go1.13 darwin/amd64

Go environment

go env Output:
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/aludirk/Library/Caches/go-build"
GOENV="/Users/aludirk/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/aludirk/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-
prefix-map=/var/folders/d3/p4n_dry12bsd4m69b_r9l9sh0000gn/T/go-build405972770=/tmp/go-build -gno-reco
rd-gcc-switches -fno-common"

gopls version

gopls version Output:
golang.org/x/tools/gopls 0.4.0
    golang.org/x/tools/gopls@v0.4.0 h1:G4+YP9kaV4dJb79J5MobyApxX493Qa6VoiTceUmxqik=  
@bhcleek
Copy link
Collaborator

bhcleek commented May 8, 2020

Thank you for the clear bug report. I'll have a fix for this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants