Some small :GoImpl improvements #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When using `:GoImpl` on `type foo struct{}` it would work, but with:
type foo struct{
}
or with a struct with fields, it would create the generated methods *inside*
the struct. Fixes #1077.
- Allow using `:GoImpl` on the `type` and `struct` parts too. Makes it a wee
bit easier to use ;-)
- Output would include extra newline, and error would include trailing newline
from shell command:
vim-go: invalid receiver: "} *}"<00>
- Small documentation fix.
|
Thanks @Carpetsmoker as always 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
:GoImplontype foo struct{}it would work, but with:or with a struct with fields, it would create the generated methods inside
the struct. Fixes GoImpl creates method stubs inside struct definiton #1077.
Allow using
:GoImplon thetypeandstructparts too. Makes it a weebit easier to use ;-)
Output would include extra newline, and error would include trailing newline
from shell command:
Small documentation fix.