Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load ftplugin/html.vim for gohtmltmpl #1442

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Load ftplugin/html.vim for gohtmltmpl #1442

merged 2 commits into from
Sep 14, 2017

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Sep 13, 2017

This will make % with the matchit plugin loaded work as expected,
and also adds some other features.


setlocal commentstring=<!--\ %s\ -->
runtime! ftplugin/html.vim
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this available by default for all Vim versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git log for runtime/ftplugin/html.vim goes back to 7.0001, so it seems so

@fatih
Copy link
Owner

fatih commented Sep 13, 2017

lgtm

bhcleek
bhcleek previously approved these changes Sep 14, 2017
Copy link
Collaborator

@bhcleek bhcleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fatih gave this LGTM, but later changed the repo to require PR approval before PRs can be merged, so I'm marking this approved for him.

Is there any reason to hold off on merging this?

This will make `%` with the `matchit` plugin loaded work as expected,
and also adds some other features.
@arp242
Copy link
Contributor Author

arp242 commented Sep 14, 2017

Ugh, I added another commit with the CHANGELOG entry and now your review got cleared @bhcleek >_<

@arp242 arp242 merged commit b319ed9 into fatih:master Sep 14, 2017
@arp242 arp242 deleted the ftplugin-html branch September 14, 2017 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants