Fix :GoBuild shell escaping #1450
Conversation
|
At some point we should ditch supporting 7.4 Not sure when, probably not in near future but we should eventually. lgtm |
I was thinking the same; Ubuntu 16.04 (the most recent LTS) has Vim 7.4.1689; the next LTS release (18.04) will have Vim 8, so that might be a good time? I also saw that some functions don't actually have async support, for example for :GoInstall it's implemented for just Vim but not Neovim. It's annoying that the APIs are different :-/ |
|
Yeah :/ The reason is that I'm not using neovim. Initially when it was released I've added some async capabilities for neovim. But then vim-go grew and grew,so I couldn't keep up with neovim support. I've decided after that vim-go should have first class support for Vim, but for Neovim it shouldn't have it. So whenever there was an issue for Neovim and I had time, I would add it. That's why the API is so different.
Yeap definitely! |
There was a stray `go#util#Shelllist()` in there. As near as I can tell this isn't needed at all. Probably a left-over from some earlier version? Also move the non-async code in an `else`, I think this makes it a lot clearer which code path does what. The two early returns were kinda confusing. Tested with Vim 8, 7.4, and Neovim, and seems to work well. Fixes #1404
There was a stray
go#util#Shelllist()in there. As near as I can tellthis isn't needed at all. Probably a left-over from some earlier
version?
Also move the non-async code in an
else, I think this makes it a lotclearer which code path does what. The two early returns were kinda
confusing.
Tested with Vim 8, 7.4, and Neovim, and seems to work well.
Fixes #1404