Fix :GoImpl completion #1581
Merged
Fix :GoImpl completion #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1554 The problem is that `:GoImpl somethingInvalid` would set `v:shell_error`, and on the next `:GoImpl <Tab>` the `go#util#env()` call in `s:root_dirs()` would use the cache, so the `v:shell_error` is "stuck". Fix it by not checking this here; `go#util#env()` already shows an error so that should be fine. Long-term fix is to use `go#util#Exec()` everywhere which returns `v:shell_error` instead of relying on a global value. While I'm here also add a basic test and use `Exec()` in a few places.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1554
The problem is that
:GoImpl somethingInvalidwould setv:shell_error, and on the next:GoImpl <Tab>thego#util#env()call in
s:root_dirs()would use the cache, so thev:shell_erroris"stuck".
Fix it by not checking this here;
go#util#env()already shows an errorso that should be fine.
Long-term fix is to use
go#util#Exec()everywhere which returnsv:shell_errorinstead of relying on a global value.While I'm here also add a basic test and use
Exec()in a few places.