Add support for denite.nvim about :GoDecls / :GoDeclsDir

[delphinus]

denite.nvim is the successor of unite.vim. This PR enables :GoDecls & :GoDeclsDir features by denite as same as unite in #1391.

" available below as same as :Unite decls
:Denite decls
:Denite decls:foo.go
:Denite decls:foo/bar

denite is written for NeoVim / Vim 8 and it uses more progressive features than unite. The expansions of denite must be written in Python3.

:Denite decls

[fatih]

Thanks @delphinus,

I'm not sure this is something I would like to merge. Who is going to maintain the python script afterwards? We already have fzf, ctrlp and unite.

[arp242]

My 2 cents is that this adding this won't affect any existing code or features. If you don't use denite.vim then you won't even know vim-go has a plugin thingy for it. If it ever breaks in the future we can just remove it if no one steps up to fix it.

[fatih]

@Carpetsmoker what do you plan if a bug report comes for denite?

[arp242]

Tell the submitter to fix it or learn to live with the bug :-) If it's a critical bug we can simply remove the denite.vim plugin if no one steps up.

[fatih]

Sounds fair :)

[arp242]

:Denite decls dir doesn't seem to work? I get [denite] NameError: Source "dir" is not found..

[delphinus]

denite needs options : separated. And the file or dir is some illustration, so users should supply the real path.

:Denite decls:~/.go/src/github.com/golang/appengine
" relative path also available. same meaning if you are in ~/.go/src/github.com
:Denite decls:golang/appengine

The description is a bit obscure maybe, but I followed descriptions already written about unite.

[arp242]

Oh, right. I normally don't use this plugin so excuse my ignorance. I've tweaked the documentation a bit, which makes it a bit clearer I think.

[arp242]

Very minor, but missing full stop or semicolon before "Possible" here.

[delphinus]

👍

[arp242]

After testing I have rplugin/python3/denite/source/__pycache__/decls.cpython-36.pyc as an untracked file in git. Would be a good idea to add that to gitignore to prevent it from being accidentally checked in.

Can just add *.pyc; that will cover this and all future cases.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@21c2629). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1604   +/-   ##
=========================================
  Coverage          ?   14.78%           
=========================================
  Files             ?       53           
  Lines             ?     4152           
  Branches          ?        0           
=========================================
  Hits              ?      614           
  Misses            ?     3538           
  Partials          ?        0

Flag	Coverage Δ
#nvim	5.05% <ø> (?)
#vim74	14.71% <ø> (?)
#vim80	14.47% <ø> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c2629...cd8c409. Read the comment docs.

[delphinus]

Added to .gitignore. check it. 👍

[fatih]

The expansions of denite must be written in Python3.

Can we include this information in the doc? I assume Vim also needs to be compiled with +python right?

[delphinus]

Added requirements for denite. 👍

[arp242]

Thanks! 👍