Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve testing story #1605

Merged
merged 2 commits into from
Dec 10, 2017
Merged

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Dec 9, 2017

  • Use a Make variable, VIMS, to specify which versions of Vim should be
    installed and tested.
  • Include Vim version in test report to make correlation easier.

With these two changes, it's much easier to test only a single version
of Vim by running something like
docker run -e VIMS=vim-8.0 -v $PWD:/vim-go vim-go-test

These changes are also included in #1583 , but it's taking me a little longer to get those done than I expected, and I've wanted the changes a couple of times while working on other things, too. Since it's separable, I figured I'd separate it :-)

* Use a Make variable, VIMS, to specify which versions of Vim should be
  installed and tested.
* Include Vim version in test report to make correlation easier.

With these two changes, it's much easier to test only a single version
of Vim by running something like
  docker run -e VIMS=vim-8.0 -v $PWD:/vim-go vim-go-test
@codecov-io
Copy link

codecov-io commented Dec 9, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@21c2629). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1605   +/-   ##
=========================================
  Coverage          ?   14.78%           
=========================================
  Files             ?       53           
  Lines             ?     4152           
  Branches          ?        0           
=========================================
  Hits              ?      614           
  Misses            ?     3538           
  Partials          ?        0
Flag Coverage Δ
#nvim 5.05% <ø> (?)
#vim74 14.71% <ø> (?)
#vim80 14.47% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c2629...1c04a68. Read the comment docs.

@arp242 arp242 merged commit 47251aa into fatih:master Dec 10, 2017
@bhcleek bhcleek deleted the tests/target-single-vim-option branch December 10, 2017 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants