Fix go#template#create() for directories that don't exist yet #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1618 +/- ##
==========================================
+ Coverage 19.15% 19.19% +0.03%
==========================================
Files 53 53
Lines 4151 4153 +2
==========================================
+ Hits 795 797 +2
Misses 3356 3356
Continue to review full report at Codecov.
|
Repository owner
deleted a comment from
bhcleek
Dec 18, 2017
Repository owner
deleted a comment from
bhcleek
Dec 18, 2017
Previously `vim ~/go/src/newdir/main.go` would result in: "~/go/src/newdir/main.go" [New DIRECTORY] Error detected while processing function <SNR>56_template_autocreate[3]..go#template#create: line 6: E344: Can't find directory "/home/martin/go/src/newdir" in cdpath E472: Command failed With this change this gets treated like a directory which isn't a Go package yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
vim ~/go/src/newdir/main.gowould result in:With this change this gets treated like a directory which isn't a Go
package yet.