fix quickfix list when test duration exceeds timeout #1633
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1633 +/- ##
==========================================
+ Coverage 19.17% 19.21% +0.03%
==========================================
Files 53 53
Lines 4156 4158 +2
==========================================
+ Hits 797 799 +2
Misses 3359 3359
Continue to review full report at Codecov.
|
autoload/go/test_test.vim
Outdated
| \ {'lnum': 0, 'bufnr': 0, 'col': 0, 'valid': 1, 'vcol': 0, 'nr': -1, 'type': '', 'pattern': '', 'text': 'panic: test timed out after 2s'} | ||
| \ ] | ||
|
|
||
| let g:go_test_timeout="2s" |
There was a problem hiding this comment.
Is it possible to use a shorter timeout here, like 100ms? Or at the very least 1s? 2 seconds isn't that long, but if you're modifying something then it's just too long for a "smooth" modify/test workflow, and these small timeouts tend to add up once the testing coverage increases.
If it's not easily possible then don't bother. It's a very small thing. Looks good otherwise 👍.
There was a problem hiding this comment.
It's possible. I just chose two seconds because it's reasonably short, and I was pretty sure everything that needs to start would actually be started in that time. I'll try dialing it back and will merge with the reduced timeout or this if it's not possible to reduce it reliably...
bhcleek
force-pushed
the
test-timeout-errors
branch
from
4895313
to
d9c6ade
Compare
Do not treat a panic caused by a test timeout as an error that occurred within a test's callstack. When go test panics due to a test timeout, the running goroutine's stacktrace only contains entries for the standard library, and there is one goroutine whose stacktrace contains entries for the standard library and the test binary. None of the other goroutines should be considered to contain an error, either, because the panic was not due to any code executing within those goroutines' stacks. Therefore, treat panics caused by a test timeout as an error without a file location.
bhcleek
force-pushed
the
test-timeout-errors
branch
from
d9c6ade
to
816cf42
Compare
Do not treat a panic caused by a test timeout as an error that occurred
within a test's callstack. When go test panics due to a test timeout,
the running goroutine's stacktrace only contains entries for the
standard library, and there is one goroutine whose stacktrace contains
entries for the standard library and the test binary. None of the other
goroutines should be considered to contain an error, either, because the
panic was not due to any code executing within those goroutines' stacks.
Therefore, treat panics caused by a test timeout as an error without a
file location.