Fix go build error parse #1716
Merged
Fix go build error parse #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1716 +/- ##
==========================================
+ Coverage 19.57% 23.82% +4.25%
==========================================
Files 57 57
Lines 4787 4784 -3
==========================================
+ Hits 937 1140 +203
+ Misses 3850 3644 -206
Continue to review full report at Codecov.
|
|
|
Parse go build errors using the same errorformat as is used by vim7.4 so that the column will be included in the quickfix error instead of being part of the error message itself.
bhcleek
force-pushed
the
fix-go-build-error-parse
branch
from
41b3169
to
f916e1e
Compare
|
☝️ fixed. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors from
:GoBuildwere including the column number in the quickfix error'stextmessage instead of it parsing it into in the quick fix error'scolfield, becauseerrorformatwasn't being using used parse the errors whengo buildwas run asynchronously.This PR uses
go#list#Parseto parse the errors so that the result in vim8 and Neovim is the same as it is in vim7.4.While I was at it, I added a test for
:GoVetand modified it to also usego#list#Parse.