run gometalinter asynchronously in Neovim #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bhcleek
commented
Jul 26, 2018
bhcleek
commented
- Run gometalinter asynchronously and vim-go's job api to to run it both Vim8 and Neovim.
- Correct a couple of documentation errors I came across during implementation.
Transform Vim8 job options in go#job#Start instead of from go#job#Options so that the callbacks can be wrapped by callers without having to worry about whether the editor is Vim8 or Neovim.
Remove calls to functions that previously only served to set a default value so that it could be restored. Now that the the default values are handled in config.vim, it's not necessary to toggle GoMetalinterAutosave() twice...
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.