put test output within its RUN and PASS/FAIL lines #1899
Conversation
|
|
|
We can bump the version; also see #1847. I think bumping the minimally required version to 7.4.2008 is reasonable. |
|
works for me. I'll re-open this and bump the version tonight. |
Update minimum required version of Vim to 7.4.2009; this ensures that `:messages clear` (needed for the changes to scripts/runtest) exists as well as `execute()` (which we want for other reasons).
|
lgtm, but add a line in changelog to |
| " release (16.04) uses. | ||
| " Version 7.4.2009 was chosen because that's greater than what the most recent Ubuntu LTS | ||
| " release (16.04) uses and has a couple of features we need (e.g. execute() | ||
| " and :message clear). |
There was a problem hiding this comment.
Note that this comment is no longer true.
There was a problem hiding this comment.
Which part isn't true?
There was a problem hiding this comment.
Oh, you mean that 16.04 isn't the most recent version of LTS anymore?
There was a problem hiding this comment.
Yeah, and that the minimal version is chosen because it's what in the most recent Ubuntu LTS.
|
A pretty annoying change IMHO. For such a cosmetic "bug" I would think most users wouldn't care about (but would care about broken code completion for example). Anyways as an Ubuntu 16.04 users I would not expect having to upgrade my OS until april 2021. So as a user I have the choice:
|
I'm sorry @benjamin-thomas, but you can't expect people to keep supporting a Vim version that's years old. Ubuntu's policy is their responsibility, not ours. 7.4.2008 is already more than two years old. Two years is a very reasonable time period to support software. Installer a newer Vim version on Ubuntu isn't very hard: https://vi.stackexchange.com/q/10817/51
It's not about this "cosmetic bug", it's about allowing vim-go to use newer and more convenient Vim features throughout. There have been a lot of changes to Vim in the last few years, and supporting older Vim versions is a bit of a pain. |
|
Please don't take it personally, I've always loved vim-go. And I don't expect anything from an opensource project. But I'll merely state that forcing an upgrade on a stable OS for no obvious reason is not reasonable at all IMO, and disappointing. And I find this new support policy to be in sharp contrast with the go mentality of having long stable tools. This is not a technical hurdle for me, more of a nuisance than anything. My 2 cents... |
Go releases aren't supported for 2+ years. There are plenty of cases where you need a minimum Go version to run something (e.g. using new sort API, subtests, loads of other stuff that was introduced fairly recent, etc.) Will you keep writing Go programs with Go 1.6 that Ubuntu 16.4 ships with until April 2021? I would hope not. |
|
The go upgrade path is painless, since you just untar the latest release when you feel like it, and you're good to go, that's what I was trying to convey. I can confirm compiling vim was a chore, and I don't want to rely on some random dude's PPA. At that point, updating my editor plugin becomes more burdensome than upgrading the underlying tool chain. I can only assume you're running a Mac, brew install and probably don't care? Anyways I've been using vim for 10 years and never faced such a requirement from a vim plugin, take it for what you will. |
Put test output within its RUN and PASS/FAIL lines so that it's easier to identify which test is providing the output.
For instance, the
Test_Vetinlint_test.vimoutputsvim-go: [vet] FAIL. Previously, this output would be output after the test results:But now, the output will be shown within the test run: