lint: remove go_metalinter_disabled option and fix tests #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the tests for golangci-lint by: * spelling g:go_metalinter_command correctly * modifying the expectations for golangci-lint now that the tests actually run it. Remove g:go_metalinter_disabled option. Given that both golangci-lint and gometalinter have all linters disabled using `--disable-all` and then only the linters in g:go_metalinter_enabled run, g:go_metalinter_disabled is extraneous. golangci-lint prevents the use of both `--disable-all` and `--disable`, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the tests for golangci-lint by:
actually run it.
Remove g:go_metalinter_disabled option. Given that both golangci-lint
and gometalinter have all linters disabled using
--disable-allandthen only the linters in g:go_metalinter_enabled run,
g:go_metalinter_disabled is extraneous. golangci-lint prevents the use
of both
--disable-alland--disable, too.