Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

term: fix terminal window sizing #2736

Merged
merged 1 commit into from
Feb 20, 2020
Merged

term: fix terminal window sizing #2736

merged 1 commit into from
Feb 20, 2020

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Feb 20, 2020

Split the terminal for Vim the same as is done for Neovim and then start
the terminal in that new buffer.

Fix a regression in Neovim's terminal window that caused it to be too
small because the height and width were based on the starting window
instead of terminal window split.

Set the window to the starting window on exit.

Fixes #2735

Split the terminal for Vim the same as is done for Neovim and then start
the terminal in that new buffer.

Fix a regression in Neovim's terminal window that caused it to be too
small because the height and width were based on the starting window
instead of terminal window split.

Set the window to the starting window on exit.

Fixes fatih#2735
@bhcleek bhcleek merged commit 10bf9a0 into fatih:master Feb 20, 2020
@bhcleek bhcleek deleted the term/sizing branch February 20, 2020 18:42
bhcleek added a commit that referenced this pull request Feb 20, 2020
@bhcleek bhcleek added this to the vim-go 1.23 milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neovim go test vertical split regression from #2639
1 participant