lsp: keep diagnostics highlighting on format #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for highlighting gopls diagnostics: * verify diagnostic highlights when a file is changed by gofmt on save. * verify diagnostic highlights when a file is saved and not changed by gofmt. * verify diagnostic highlights when a file is reloaded. Cleanup a file added by gotest#write_file that was previously left around. Add a # Please enter the commit message for your changes. Lines starting
Preserve highlight of gopls sourced diagnostics when formatting.
Use `has('textprop')` instead of exists('*prop_remove') to determine
whether to use text properties.
Try to preserve column after formatting by shifting the cursor over when
the line has indentation added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt: add tests for highlighting gopls diagnostics
Add tests for highlighting gopls diagnostics:
gofmt.
Cleanup a file added by gotest#write_file that was previously left
around.
Add a # Please enter the commit message for your changes. Lines starting
fmt: preserve gopls diagnostic highlighting
Preserve highlight of gopls sourced diagnostics when formatting.
Use
has('textprop')instead of exists('*prop_remove') to determinewhether to use text properties.
Try to preserve column after formatting by shifting the cursor over when
the line has indentation added.
Fixes #2753