debug: handle process exits cleanly #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
force-pushed
the
debug/stop-on-exit
branch
7 times, most recently
from
396a0ba
to
8a06e21
Compare
Quit the debugger when the process being debugged stops.
Add context to error messages so that it's easier to understand fron where they originate.
Extract the NextInProgress handling to its own function for readability.
Vim's sign place command may output lines that either begin or end with Signs. The former seems to be most common, but the latter is possible, so handle that case. Fixes fatih#2920
Use sign_getplaced() when it exists instead of `:sign placed`, so that output of the normal mode command doesn't have to be parsed to get the signs.
bhcleek
force-pushed
the
debug/stop-on-exit
branch
from
8a06e21
to
8e8c0f2
Compare
bhcleek
added a commit
that referenced
this pull request
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the debugging experience when the process being debugged exits. Previously the debugger would stay active, some unexpected messages would be shown to the user, and a
:GoDebugContinuewould restart the application.explain why CancelNext needs to be called
debug: handle process exit cleanly
Quit the debugger when the process being debugged stops.
debug: make error messages more useful
Add context to error messages so that it's easier to understand fron
where they originate.
debug: refactor NextInProgress handling
Extract the NextInProgress handling to its own function for readability.
Fixes #2920