Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/evaluation objects in objectives #66

Merged
merged 4 commits into from Dec 9, 2023
Merged

Fix/evaluation objects in objectives #66

merged 4 commits into from Dec 9, 2023

Conversation

schmoelder
Copy link
Contributor

This PR addresses two main issues related to OptimizationProblem:

  • Ensure that only registered evaluation objects are evaluated when associated with a specific objective function.
  • Fix the incorrect labeling of objective functions when multiple evaluation objects are involved.

Details

  • Previously, all evaluation objects added to an OptimizationProblem were evaluated, regardless of whether they were registered to a particular objective function. This PR modifies the behavior to only evaluate the registered evaluation objects.
  • The PR also corrects the objective labels returned when multiple evaluation objects are added to an OptimizationProblem.

@schmoelder schmoelder force-pushed the fix/evaluation_objects_in_objectives branch from 0bd15f9 to 7454eee Compare November 2, 2023 15:03
@schmoelder schmoelder force-pushed the fix/evaluation_objects_in_objectives branch from 7454eee to 3f80983 Compare November 24, 2023 08:03
@schmoelder schmoelder force-pushed the fix/evaluation_objects_in_objectives branch from 3f80983 to 19ce37f Compare December 7, 2023 11:51
@ronald-jaepel ronald-jaepel mentioned this pull request Dec 7, 2023
Merged
@schmoelder schmoelder force-pushed the fix/evaluation_objects_in_objectives branch from 19ce37f to 3c06825 Compare December 9, 2023 16:48
@schmoelder schmoelder merged commit 57be867 into dev Dec 9, 2023
4 of 5 checks passed
@schmoelder schmoelder deleted the fix/evaluation_objects_in_objectives branch February 7, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@schmoelder