Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for binding parameters #80

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ronald-jaepel
Copy link
Collaborator

Here I've expanded the example library to include SMA parameter determinations using the Yamamoto method and the inverse method.

This contains changes from the branch #66 and should be merged after #66 is merged.

@schmoelder
Copy link
Contributor

Thanks for this! #66 is now merged; please rebase onto dev.

This could be a good idea to reconsider the structure of our examples. A long standing wish is to separate them into individual repositories where we can side-load optimization results using something like CADET-RDM.

@ronald-jaepel ronald-jaepel force-pushed the feature/add_examples_for_binding_parameters branch from dc47eed to d497d0c Compare December 11, 2023 15:09
@ronald-jaepel
Copy link
Collaborator Author

Done. Let's talk about the restructuring on Tuesday. I'll create an issue for that for now.

@schmoelder
Copy link
Contributor

You might also wanna include the example in the docs here

@ronald-jaepel ronald-jaepel force-pushed the feature/add_examples_for_binding_parameters branch from 0c07d21 to 5013f57 Compare December 15, 2023 11:35
@ronald-jaepel ronald-jaepel force-pushed the feature/add_examples_for_binding_parameters branch from 5013f57 to d2479ad Compare December 15, 2023 11:36
@ronald-jaepel
Copy link
Collaborator Author

Done.

@ronald-jaepel
Copy link
Collaborator Author

The test fails due to a disk-cache error that I can not reproduce locally. On Windows and Linux all tests complete fine.

@ronald-jaepel
Copy link
Collaborator Author

Tests completed, todos done. I think this can be merged.

@schmoelder
Copy link
Contributor

Nice, just for peace of mind, did you also build the docs locally to check that they work properly?
(might also be a good idea for further CI tests).

@ronald-jaepel ronald-jaepel merged commit c5ecf3f into dev Jan 9, 2024
5 checks passed
@ronald-jaepel ronald-jaepel deleted the feature/add_examples_for_binding_parameters branch January 9, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants