Notify Chewie of port status events.

[Bairdo]

Also added code to explicitly remove the ACLs from the port_acl table, although this isn't actually necessary as the caller clears the table for anything that matches the port number.

https://travis-ci.org/Bairdo/faucet/builds/452148059

[codecov]

Codecov Report

Merging #2623 into master will decrease coverage by 0.09%.
The diff coverage is 20%.

@@            Coverage Diff            @@
##           master    #2623     +/-   ##
=========================================
- Coverage   92.15%   92.05%   -0.1%     
=========================================
  Files          42       42             
  Lines        6077     6083      +6     
=========================================
  Hits         5600     5600             
- Misses        477      483      +6

Impacted Files	Coverage Δ
faucet/faucet_dot1x.py	35.71% <16.66%> (-1.52%)	⬇️
faucet/valve.py	94.33% <25%> (-0.22%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce10cfc...0e66825. Read the comment docs.

[Bairdo]

I've rerun the failing test on my travis-ci 3 times, and it has not failed again, so possibly a timing issue??
latest run https://travis-ci.org/Bairdo/faucet/jobs/452148067

[gizmoguy]

I reran on our travis instance three times and always see the same failure:

======================================================================
FAIL: mininet_tests.Faucet8021XPortStatusTest.test_untagged (subunit.RemotedTestCase)
mininet_tests.Faucet8021XPortStatusTest.test_untagged
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/faucet-src/tests/integration/mininet_tests.py", line 626, in test_untagged
    self.scrape_prometheus_var('port_dot1x_success', labels={'port': 1}, default=0))
  File "/usr/lib/python3.5/unittest/case.py", line 820, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.5/unittest/case.py", line 813, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: 1 != 0

[gizmoguy]

Same failure again 😞

[Bairdo]

Yea, I've down merged master in on another branch and got it failing on my instance of travis now.

50 retries doesn't help either

[Bairdo]

downmerge issue is probably the prometheus rename. "**_total"

[Bairdo]

still fails

[byllyfish]

It's the labels. Use self.port_labels() to construct the label; it now prepends a 'b' to stuff.

'port_dot1x_success_total{dp_id="0xf0bcfbf4",dp_name="faucet-1",port="b1",port_description="b1"} 1.0',

[gizmoguy]

Okay looks like this is mostly passing now, unfortunately #2647 broke builds for faucet@master. We're just working on a fix now and when that works I'll let you know to rebase which should make your tests pass again.

[Bairdo]

Thanks @byllyfish.

[gizmoguy]

Okay turns out we had a few problems caused by faucetsdn/docker-test-base#9, I have reverted this change and fixed the clib failures we were seeing in #2652.

Rebase on master and this should work now, sorry about all the fuss!

[codecov]

Codecov Report

Merging #2623 into master will decrease coverage by 0.09%.
The diff coverage is 28.57%.

@@           Coverage Diff            @@
##           master   #2623     +/-   ##
========================================
- Coverage   92.09%     92%   -0.1%     
========================================
  Files          42      42             
  Lines        6082    6088      +6     
========================================
  Hits         5601    5601             
- Misses        481     487      +6

Impacted Files	Coverage Δ
faucet/valve.py	94.33% <25%> (-0.22%)	⬇️
faucet/faucet_dot1x.py	34.31% <33.33%> (-1.41%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace4460...4e06ac7. Read the comment docs.

[Bairdo]

FaucetDockerHostTest failed, which I've seen fail at other times, is there something in particular that causes it to fail?

[gizmoguy]

Hmmmm okay. I thought I had fixed this bug.

Basically the clib tests want to use docker-in-docker which can be unreliable when not done correctly. I will keep investigating at my end and try get to the bottom of this and let you know when it's safe to rebase again.

Sorry again for the disruption.

[gizmoguy]

hi @Bairdo I finally got this fixed properly in #2657 try a rebase against faucet@master now and that should get you passing again

[gizmoguy]

Sorry again, you managed to grab faucet@master during our release process which means the version number wasn't set correctly so your tests failed again. Give it one more rebase and you'll be good to go finally

[gizmoguy]

We have a bit of a messy system for handling interface numbers now in case the end user is not using ports 1-4 in their hardware test bed.

For now you can use portN instead of the integers to set which port you are referring to.

[Bairdo]

I've just updated the docs to mention we support TLS (as of v0.0.10), and PEAP (there is a PR in chewie). I can back it out if it should be in another pr.

[gizmoguy]

Yeah put the documentation change in a separate PR.

[anarkiwi]

Does this PR now pass, on a hardware test bed using not ports 1-4?

[Bairdo]

all 1x tests pass on c9300 not using ports 1,2,3,4