Swarm #394
Merged
Swarm #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce first config phase, "applied", in which a device is sent one or more inline payloads or URLs to retrieve. The device then applies the payloads.
bin/test_redirect
Outdated
| fi | ||
|
|
||
| site_path=sites/udmi_site_model | ||
| device_id=AHU-22 |
There was a problem hiding this comment.
can it be made clear why this is hardcoded?
There was a problem hiding this comment.
added comment (it's just hardcoded for testing)
|
|
||
| pids=`ps ax | fgrep pubber | fgrep java | awk '{print $1}'` | ||
| if [[ -n $pids ]]; then | ||
| echo Killing pubber pids $pids |
There was a problem hiding this comment.
This should really be lock files etc instead of ps grepping.. at some point
johnrandolph
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging swarm sprint branch into master. These changes have already been somewhat reviewed as parts of other PRs.